search

tumblr / k8s-sidecar-injector

Kubernetes sidecar injection service
Apache License 2.0
345 stars 75 forks source link

Remove ignored namespaces check #53

Open ribbybibby opened 4 years ago

ribbybibby commented 4 years ago

What and why?

Fixes #44 and #52.

Remove the ignored namespaces check from the code in favour of a namespaceSelector in the webhook example. Not only does this allow users to inject into pods in kube-system if they want to, it also provides more protection against problems with the webhook as pods from ignored namespaces won't be forwarded to the webhook at all.

This PR also tweaks the logging in the mutate function to account for the fact that the object metadata may not contain name or namespace information.

Testing Steps

Please provide adequate testing steps (including screenshots if necessary). Include any test fixtures or sample configurations in your commit.

Reviewers

Required reviewers: @byxorna Request reviews from other people you want to review this PR in the "Reviewers" section on the right.

:warning: this PR must have at least 2 thumbs from the MAINTAINERS.md of the project before merging!

ribbybibby commented 4 years ago

Ping - just checking if anyone has had a chance to look at this?