search

tumblr / pytumblr

A Python Tumblr API v2 Client
Apache License 2.0
723 stars 196 forks source link

Updating contribution guideliness #129

Closed omergulen closed 5 years ago

omergulen commented 5 years ago

It was old version so I updated it with adding the new link (https://yahoocla.herokuapp.com/) and simple guideline sentence.

omergulen commented 5 years ago

A review is being waited. @komapa

komapa commented 5 years ago

We are cleaning up the CONTRIBUTING docs across all of our projects so this PR is superseded by https://github.com/tumblr/pytumblr/pull/132 Thanks for pointing this out!

omergulen commented 5 years ago

Tbh, I didn't get what is the difference with #132 and my PR. Why mine is closed and #132 will be accepted. @komapa

komapa commented 5 years ago

The difference is that the text from #132 is what we are standardizing around in all of our repos. Yours point to the same location but the wording is different.

omergulen commented 5 years ago

Generally in this kind of cases, old PR is the one who would be committed with fixes. But you know the best, what can I say, right?

komapa commented 5 years ago

When it comes to legal text, it is better to come from a contributor. No hard feelings, anyway nobody gets bonus points for this :) Looking forward to more contributions from you.