search

tumblr / pytumblr

A Python Tumblr API v2 Client
Apache License 2.0
723 stars 196 forks source link

Fix Unicode issues (#58) #65

Closed rbreu closed 7 years ago

rbreu commented 9 years ago

This should fix the issues mentioned in #58. I've manually tested the upload of an image file which contains umlauts in the filename, and getting posts by a tag containing umlauts.

Unfortunately, I had problems mocking the open function in the UnitTests. That part was commented, so I guess I wasn't the only one. ;) With open mocked, mimetypes.guess_types hangs infinitely. I could work around that by mocking guess_types as well, though that means mocking away part of what we want to test. It's better than nothing, though.

jasonpenny commented 7 years ago

Thank you for your submission (from years ago), a recent PR that was merged looks like it works with unicode tags and filenames