search

tumblr / pytumblr

A Python Tumblr API v2 Client
Apache License 2.0
723 stars 196 forks source link

Requests wait indefinitely (no timeout) #82

Open AlmightyOatmeal opened 8 years ago

AlmightyOatmeal commented 8 years ago

While iterating through posts, occasionally it will just sit... and sit... and sit... and sit...

By default, the httplib module that the oauth2 module uses has no timeout which means it will sit indefinitely. I'm not sure why nobody thought of this yet but why isn't there a default timeout set? I did it by creating a simple decorator and applying it to TumblrRequest().get().

Before signing my life away (CLA) and contributing my code, I thought I would bring this topic up and see if someone has already worked on this idea.

xavyjs commented 7 years ago

@AlmightyOatmeal I have experienced the same issue when fetching more posts. Pls. share your solution if it is thread safe.

jasonpenny commented 6 years ago

Do you know if this is still an issue now that this module uses requests?