search

tumblr / tumblr_client

A Ruby Wrapper for the Tumblr v2 API
Apache License 2.0
224 stars 86 forks source link

Add compatibility with faraday 0.9.0 #32

Closed povilasjurcys closed 10 years ago

povilasjurcys commented 10 years ago

If I use faraday 0.9.0 I get: undefined methodclient=' for # ` That's because Faraday become very strict for provided params. My fix does not include client param on Faraday initialization, so Faraday does not complains.

kxhitiz commented 10 years ago

:+1: Does the job.

barnett commented 10 years ago

Why isn't this merged yet? The error is still prevalent.

Or any work-around, tried adding the file locally but still was broken for me.

codingjester commented 10 years ago

So I'm willing to pull this in, but does it have backwards compatibility for < 0.9.0?. @bloomrain do you happen to know?

povilasjurcys commented 10 years ago

@codingjester, I never tested it with faraday < 0.9.0. Fix only makes sure that client value in params does not go to Faraday. I think Faraday < 0.9.0 just ignores this value anyway.

doits commented 10 years ago

just stumbled on this, too. In faraday 0.8.9 there is no parameter client, either, see http://rubydoc.info/gems/faraday/0.8.9/Faraday/Connection:initialize

eagletmt commented 10 years ago

:+1:

andey commented 10 years ago

+1, let's get this merged

codingjester commented 10 years ago

Running tests on the branch now :)

codingjester commented 10 years ago

Pulling it in now. And we're going to cut a minor release.

codingjester commented 10 years ago

Cut and released for 0.8.3