search

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).
Other
50 stars 23 forks source link

Implementing IfcIndexedPolygonalFaceWithVoids #448

Closed SamuilsRulovs closed 3 years ago

SamuilsRulovs commented 3 years ago

Fixes #61 closes #317

SamuilsRulovs commented 3 years ago

I have moved part of the code from GeomUtils::extrude function, however I guess it is not correct right. I will be looking for a solution, how to change this function, so it would be possible to use it in both functions (in Geomutils::extrude and convertIfcIndexedFaceWithVoids).

pjanck commented 3 years ago

Does this supersede #342 ?

SamuilsRulovs commented 3 years ago

Does this supersede #342 ?

Yes, it is. As I checked #342 only adds unit test for "polygonal -face-tessellation", but it does not actually adress issues #61 and #317

SamuilsRulovs commented 3 years ago

I am going to move IndexedPolygonalFaceWithVoids to the separate function, but overall IndexedPolygonalFaceWithVoids is working now