tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).
Other
48 stars 22 forks source link

Fix #433: Reimplementation of IfcFixedReferenceSweptAreaSolid #458

Closed christophKaiser closed 3 years ago

christophKaiser commented 3 years ago

Fixes #433

The function was implemented by pull request #406. The code of this reimplementation was copied (with slight adaptions of variable names and one function parameter) from commit 6035ec2 "implemented support for IfcFixedReferenceSweptAreaSolid" (Stefan Jaud, 15th March 2021), respectively commit c0f621c "Merge pull request #406 from pjanck/Solving405" (Stefan Jaud, 16th March 2021).

Now, the opening of the file in the viewport (UI) and execution of the unit test work again.

I was interested in how the function convertIfcFixedReferenceSweptAreaSolid generates the surface with PolyhedronData, because my current issues about IfcAdvancedBrep with involved IfcBSplineSurfaceWithKnots probably will have to deal with PolyhedronData as well. Surprisingly, the function was empty. It seems like the code was somehow lost by a merge commit.