tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).
Other
50 stars 23 forks source link

[WIP] Implementing new unit tests for IFC4X3_ RC4 #478

Open Elvira2227 opened 3 years ago

Elvira2227 commented 3 years ago

NOTE: this pull request was created to replace the old #477, because the old PR was showing changes from other reguest, which is an error

Elvira2227 commented 2 years ago

In the last commit new unit tests were added for clothoid and line. The tests also contain images. There are some problems with previos geometries:

  1. Incircular-arc and helmert-curve there are visible geometry on the UI, but some tests (VertexViews and PlaneSurfaceViews) are failed.
  2. In cosine-curve and sinethere are no visible geometry in the UI. And also some tests are failed
  3. cubic, viennese-bend produce errors by testing geometry in the UI

And some screen shots:

image

image

Elvira2227 commented 2 years ago

And there is a question about how does the AllEntitiesAreRead work? or how must it work correctly? Usually we should count the numbers of entities, but in the last test it counts only the number of the type unsigned __int64 (and what does it mean exactly?). For example, in clothoid there are 80 entities and while launching local debugger the test AllEntitiesAreRead fails (see a screen shot).

image

Elvira2227 commented 2 years ago

In the last commit 71f684b screenshots were updated. New screenshots contain only main and top view (Unnecessary Test was deleted).