search

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).
Other
48 stars 22 forks source link

[BUG] Get_OKLABI.cmd is not working properly #480

Closed SamuilsRulovs closed 2 years ago

SamuilsRulovs commented 2 years ago

Describe the bug Get_OKLABI.cmd should be updated, thus it could download new version of OKLABI

To Reproduce Steps to reproduce the behavior:

  1. In File Explorer open source folder
  2. Open "external" folder
  3. Click on "Get_OKLABI.cmd"
  4. See error

Expected behavior Though this program OKLABI should be installed in C:\thirdparty\vs2015\x64

Additional context Add any other context about the problem here.

jschlenger commented 2 years ago

We used OKLABI to support the OKSTRA format. Since we are currently not supporting it anymore this step of executing Get_Oklabi.cmd can be skipped. I already adjusted this in the new documentation that will come with the VS2019 update.

SamuilsRulovs commented 2 years ago

Ok, however during Installation of OIP with @Elvira2227, we always had some issues building it, until I sent her my OKLABI files (since she could not download it herself through get_OKLABI.cmd anymore)

jschlenger commented 2 years ago

Thanks for letting me know. I will double check that with VS 2019 it will work without using get_OKLABI.cmd.

jschlenger commented 2 years ago

With VS2019 get_OKLABI.cmd is not needed anymore.