Unit tests for OFF Files

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).

Other

48 stars 22 forks source link

Unit tests for OFF Files #485

Closed Elvira2227 closed 2 years ago

Elvira2227 commented 2 years ago

Fixes #381

New unit tests for the .off files are added

NOTE: Producing screen shots is in progress

Elvira2227 commented 2 years ago

Regarding cube. I am recieving an Exception in Line 303 in D3D11RenderSystem.cpp

We with @SamuilsRulovs think, that it is something to do with sub variable, because it is empty.

pjanck commented 2 years ago

And not with the others? Weird. This shouldn't happen, not in the BlueFramework backend.

I see several possibilities:

is the source code of the unit test's .cpp different then that of other passing unit tests?
is the cube example file somehow polluted?

Elvira2227 commented 2 years ago

In the last commit f2f70db added new unit test for colored cube. Producing scr's for new one only after merging #484

@pjanck I sudgest that the problem is in the low file size. (The code and the .off file is usual and hav'nt any difference then that other. I have produced new unit test for colored cube and it compiled without any problem.

NOTE: After merging #484 we need update all screen shots ,because the default color was changed in "TUM-blue"

Elvira2227 commented 2 years ago

In the last commit d42fc1c were colors for all unit tests updated. Cube have still problem with producing screen shots. Should it deleted from unit tests (we have also same geometry "cube_colored" without any problems)?

jschlenger commented 2 years ago

Yes, I suggest to delete it.