Creating Unit test for BIN file folder

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).

Other

48 stars 22 forks source link

Creating Unit test for BIN file folder #525

Closed SamuilsRulovs closed 2 years ago

SamuilsRulovs commented 2 years ago

Fixes #526

SamuilsRulovs commented 2 years ago

If you have time, I would like to discuss possible solutions how to implement this. I guess, I am a little bit stuck and confused.

SamuilsRulovs commented 2 years ago

After correcting everything as we discussed yesterday, there are several errors shown up. These are regarding pointCloudGeometryEffect. Normally (by IFC and Off) there were 4 arguments in IfcGeometryEffect and OffEffect, however in pointCloudGeometryEffect there are 5 arguments needed. But VS don't like having 5 arguments either.

SamuilsRulovs commented 2 years ago

There is exception thrown, which somehow is connected to vertexBuffer

pjanck commented 2 years ago

There are still comments in the code, either unused code or reference to off - this should be corrected. Otherwise, awesome work!

SamuilsRulovs commented 2 years ago

I deleted commented code. I guess it is ready to be merged