File which is being refactoredOpenInfraPlatform::Core::IfcGeometryConverter::CurveConverterT
Functions
(convertIfcLoop - already refactored, just mentioned as 'root'-function)
[ ] convertIfcPolyLoop (in secondary scope of the intended refactoring, further inspection during refactoring)
[ ] convertIfcEdgeLoop
This is one big function, which handles many subtypes. Probably, it will be split into some smaller functions. Furthermore, a few TODOs are in the code.
The need of refactoring the function convertIfcEdgeLoop came up during the implementation of IfcAdvancedFace. I was surprised that the example files in pull request #462 work, even without the existence of functions like convertIfcOrientedEdge, convertIfcEdgeCurve, or convertIfcVertex. These entities are used in the example files. Probably, they are somehow mixed into the function convertIfcEdgeLoop. With refactoring, the structure of convertIfcEdgeLoop should be cleaned up.
File which is being refactored
OpenInfraPlatform::Core::IfcGeometryConverter::CurveConverterTFunctions
convertIfcLoop- already refactored, just mentioned as 'root'-function)convertIfcPolyLoop(in secondary scope of the intended refactoring, further inspection during refactoring)convertIfcEdgeLoopThis is one big function, which handles many subtypes. Probably, it will be split into some smaller functions. Furthermore, a few TODOs are in the code.The need of refactoring the function
convertIfcEdgeLoopcame up during the implementation ofIfcAdvancedFace. I was surprised that the example files in pull request #462 work, even without the existence of functions likeconvertIfcOrientedEdge,convertIfcEdgeCurve, orconvertIfcVertex. These entities are used in the example files. Probably, they are somehow mixed into the functionconvertIfcEdgeLoop. With refactoring, the structure ofconvertIfcEdgeLoopshould be cleaned up.