Decreased density of mesh grid lines on B-spline surface

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).

Other

50 stars 23 forks source link

Decreased density of mesh grid lines on B-spline surface #547

Closed christophKaiser closed 2 years ago

christophKaiser commented 2 years ago

New algorithm which skips evaluation points of B-spline surfaces to decrease their density. Will close #542.

The adjustment in commit 5473e99 affects all B-splines - curves and surfaces. I though this change would be nice to achieve an even subdivision (issue of +/-1, if switch from points to spaces between points). The even subdivition leads to a homogeneous size of grid squares, thus a nice visualisation.

Pending:

[x] Update Unit Tests which include B-splines (curves and surfaces). Would wait until there isn't a major change in code.

christophKaiser commented 2 years ago

Missed comment about last commits. The resent seven commits update the unit tests which contain B-spline curves and surfaces. The update of curves is included, because the previous commit 5473e99 changed the number of evaluation points (curve points). The change in the visualization is just very minor, because only one point is added. However, the updates are done to apply the changes continuously.

christophKaiser commented 2 years ago

Could you update the release notes , just making a very small entry about this change?

Done in commit fdb4827. I'm not sure about the category Various improvements. However, I haven't found a better one in the little amount of time.