tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).
Other
50 stars 23 forks source link

IfcSecondOrderPolynomial #551

Closed Elvira2227 closed 2 years ago

Elvira2227 commented 2 years ago

In this pull request I implemented functions for reading the IfcSecondOrderPolynomialSpiral. Now we can implement "Helmert curve" and this pull request can be addressed to issue #524. In the CurveConverter.h I added:

  1. getPointOnCurve()
  2. getDirectionOfCurve()
  3. additional statement in convertIfcCurveSegment()

Here you can see the screen shot (it presents HelmertCurve_100.0_300_1000_1_Meter) : image

jschlenger commented 2 years ago

It seems like quite some changes that were made for IfcSine are reverted in this pull request, which is most probably not intended. Also some bspline sreenshots that were change recently are reverted here. I think that should not be the case. Maybe pulling the most recent changes from the development branch could help. Let me know in case there are any issues, it seems like you tried to merge but then reverted it.