search

tumcms / Open-Infra-Platform

This is the official repository of the open-source Open Infra Platform software (as of April 2020).
Other
47 stars 21 forks source link

IfcSeventhOrderPolynomialSpiral #552

Closed Elvira2227 closed 1 year ago

Elvira2227 commented 2 years ago

In this pull request I implemented functions for reading the IfcThirdOrderPolynomialSpiral. Now we can implement "VienneseBend curve" and this pull request can be addressed to issue #524. In the CurveConverter.h I added:

  1. getPointOnCurve()
  2. getDirectionOfCurve()
  3. additional statement in convertIfcCurveSegment()

During visualisation, there is an error in the unit test data #478.

  1. Line 98 parameter ParentCurve is missing
jschlenger commented 1 year ago

Is just the unit test not working properly? Does the visualization in OIP work?

jschlenger commented 1 year ago

Can you create an issue to check for the correctness of IfcSeventhOrderPolynomialSpiral with an example file? I know the code is very similar to other polynomial spirals, nevertheless to remember to check its functionality as soon as we have an example file.