search

tumi8 / vermont

Vermont (VERsatile MONitoring Toolkit) is an open-source software toolkit for the creation and processing of network flow data.
https://www.net.in.tum.de/research/software/#vermont
GNU General Public License v2.0
56 stars 22 forks source link

Properly remove DataTemplates #110

Open ogasser opened 6 years ago

ogasser commented 6 years ago

We should go through the code to remove all DataTemplates code. PR #69 was a good first step, but there is more to remove :)

List of files with DataTemplates code:

Comments in files mentioning DataTemplates:

nickbroon commented 6 years ago

i might be mis-understanding the code, but in the case of src/modules/ipfix/aggregator/BaseHashtable.cpp and src/modules/ipfix/aggregator/BaseHashtable.h I think the dataTemplate references are actually just the regular templates that describe the data records in the hash tables. I don't believe they are actually represent IpfixDataTemplate. Perhaps it should be called Template in this use?

ogasser commented 6 years ago

@nickbroon yep, if we mean regular templates we should rename the DataTemplate to Template.

nickbroon commented 5 years ago

'dataTemplateInfo' could be replaced with 'templateInfo' using sed. 'dataTemplate' could not be replace with 'template' as 'template' is C++ reserved word. It could be replace with 'Template' but that does not follow camalCase convention for variables and would probably still be rather confusing. Suggestions welcome. (I think I'm inclined to think that dataTemplate is reasonable here as it's a template that describes ipfix data, which could be contrasted with say an optionTemplate which describes ipfix options. https://www.google.com/search?q=ipfix+%22data+template%22 )

ogasser commented 5 years ago

dataTemplate sounds good to me :+1: