search

tumic0 / GPXSee-maps

GPXSee maps
https://maps.gpxsee.org
The Unlicense
35 stars 10 forks source link

Added Karjalankartta map #4

Closed sikmir closed 6 years ago

sikmir commented 6 years ago

Karelian Maps:

There are maps of the Karelian Isthmus and Ladoga Karelia drawn up by the National Land Survey and the Topographic Service of the Finnish military before 1939.

  1. The map works with the latest released GPXSee version: screenshot1
  2. The map validates against the latest map xsd schema: 
    $ wget http://www.gpxsee.org/map/1/map.xsd
$ xmllint -schema map.xsd Karjalankartta.xml --noout
Karjalankartta.xml validates
  3. Using the map data in GPXSee is not prohibited by the map license: Terms of use
tumic0 commented 6 years ago

Please remove the axis="yx" attribute. The server serves the map in the correct axis order, so it is not required (the argument shall indicate a workaround for broken WMS 1.3.0 servers).

The limitation that the axis order has to be defined is no more true for the final WMS implementation, like it was when you created the map.

sikmir commented 6 years ago

Well, updated.

P.S.: please don't close PRs just because some updates are required. I could fix and rebase my branch, but now I will have to create another one duplicate PR.

tumic0 commented 6 years ago

Sorry, I'm not that familiar with the GitHub flow. But right after I have closed the PR I was thinking there most probably is some mechanism to edit the PR... ;-)