search

tumic0 / GPXSee-maps

GPXSee maps
https://maps.gpxsee.org
The Unlicense
35 stars 10 forks source link

Added Thunderforest maps #7

Closed sikmir closed 6 years ago

sikmir commented 6 years ago
tumic0 commented 6 years ago

I'm really in doubts whether we shall enable maps that don't work "out-of-the-box". They may look "broken" for many users...

sikmir commented 6 years ago

We can remove ?apikey=insert-your-apikey-here part. So result will be more "workable": screenshot1 Anyway these maps are very popular.

tumic0 commented 6 years ago

Yes, but then adding the API key will not be that easy as people would have to search for the parameter name. My idea is to let the parameter there, but name the file not .xml but .tpl (or *.template). This way people would see that it is a template (and it won't be possible to load it into GPXSee unless they change the extension)

sikmir commented 6 years ago

This sounds reasonable. Let's do it in such a way. Updated.

sikmir commented 6 years ago

GH is confused about *.tpl files: screenshot1 Linguist definition for Smarty: https://github.com/github/linguist/blob/cc4da9861689e2a2ec9a7602c2b0b0163619a66a/lib/linguist/languages.yml#L4419-L4427 You can fix it by adding:

$ echo "*.tpl linguist-language=xml" > .gitattributes