search

tuminfei / icrc7_launchpad

An example implementation of ICRC7 containing ICRC37 and ICRC3 standards.
MIT License
6 stars 2 forks source link

Burn() transactions not deleting NFTs. #5

Closed evanmcfarland closed 2 weeks ago

evanmcfarland commented 3 weeks ago

Use of the burn function does not delete the nft. Metadata, owner, etc., are still retrievable.

Screenshot from 2024-06-28 14-56-03

Everything else works great though. Thanks so much for this implementation Terry. I also had a similar implementation made that might be helpful to you and I'm deciding which to use: https://github.com/UncensoredGreats/NFT/

tuminfei commented 3 weeks ago

The implementation of the burn method does not delete, but transfers the token to a burn_address address (similar to a 0 address).

You can see the burn event by querying an nft event logs.

image
evanmcfarland commented 3 weeks ago

If I'm not mistaken, tokens_of(), balance_of(), and owner_of() still show the principal and sub-account of the original holder before the burn. Is there a function that lets you know if an NFT is burned or not?

tuminfei commented 3 weeks ago

Thanks for your feedback, I have fixed the bug in the burn function.

tuminfei commented 2 weeks ago

If the problem has been solved, I will close this issue.