search

tummychow / git-absorb

git commit --fixup, but automatic
https://crates.io/crates/git-absorb
BSD 3-Clause "New" or "Revised" License
4.64k stars 71 forks source link

Error handling update: thiserror or anyhow #31

Closed alexmaco closed 4 years ago

alexmaco commented 4 years ago

Since failure is effectively deprecated and unmaintained, I'd like to update the error handling lib.

@tummychow which would you prefer between these 2 ? Anyhow seems more oriented to binaries, so that's what I would go for. Thiserror seems more suited to libraries, however the library form of git-absorb only has one function, so not sure how much value does detailed error insppection brings.

tummychow commented 4 years ago

i'm amenable to an anyhow port. just swapping it in for failure::Error is fine with me, no need for custom error types