tummychow / git-absorb

git commit --fixup, but automatic
https://crates.io/crates/git-absorb
BSD 3-Clause "New" or "Revised" License
4.64k stars 71 forks source link

Remove unused `by_old` function #61

Closed orhun closed 2 years ago

orhun commented 2 years ago

This PR removes the following warning that I came across while building git-absorb:

   Compiling git-absorb v0.6.7 (/build/git-absorb/src/git-absorb-0.6.7)
warning: associated function is never used: `by_old`
  --> src/owned.rs:45:12
   |
45 |     pub fn by_old(&self, path: &[u8]) -> Option<&Patch> {
   |            ^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
tummychow commented 2 years ago

i kind of like having both by_old and by_new for symmetry... but yeah should probably delete it lol