tumpio / gmscripts

tumpio's usercripts
https://openuserjs.org/users/tumpio
MIT License
61 stars 28 forks source link

Uncaught TypeError: Cannot read property 'getElementsByClassName' of null #1

Closed ArnaudLoos closed 9 years ago

ArnaudLoos commented 9 years ago

Extension: DuckDuckGo_Extended. Chrome Inspector showing the following error "Uncaught TypeError: Cannot read property 'getElementsByClassName' of null" from script.js line 349. Indeed document.getElementById("header_button_menu") does return null.

tumpio commented 9 years ago

Ah this was fixed month ago in https://github.com/tumpio/gmscripts/commit/ea8a693292de6492aad9a8c7570f12c2d0c875a4

Uploaded to openuserjs. I don't know why the web hook doesn't work now.

Martii commented 8 years ago

@tumpio

I don't know why the web hook doesn't work now.

There was one point where certain scripts got unsync'd... however it should be fixed now. All you need to do is reimport it via the GitHub import section... that will retain your stats... this is assuming you still have the webhook enabled here on GH.

Btw I know for sure that egoogle.user.js is out of sync right now... so you should just be able to reimport that and if all goes well you should be good to go.

Please let me know if you are having issues so I can try to assist you. :)

OUJS Admin


P.S. Please ensure that your Content Type is application/x-www-form-urlencoded for the webhook configuration here on GH. That was one of the docs we fixed really early when I came on board.

tumpio commented 8 years ago

@Martii Thank you for letting me know! I did as you suggested. The content type for the webhook was application/json. I changed it as well. Now I'll have to work on my scripts to test the hook! :+1:

Have a great week! :)

Martii commented 8 years ago

@tumpio No problem... I do suggest in the future that you increment @version though when you make a script change (even on your external changes with CSS at userstyles)... makes it a little easier for everyone to get notified of updates as well as the specific tracking on what happened way back then. :)

I've manually rechecked your entire account and reset a few things from all the fixes we've done since those times.

Enjoy, OUJS Admin