tumpio / requestcontrol

A Firefox extension

https://addons.mozilla.org/addon/requestcontrol

Mozilla Public License 2.0

172 stars 25 forks source link

Unbreak sites #137

Closed ArenaL5 closed 3 years ago

ArenaL5 commented 3 years ago

Merry Christmas! :christmas_tree:

Thank you so much for splitting the rules into several files and lhaving instructions for the linter. It will be so much easier to update the filters from now on.

This PR is mainly because this Christmas I've tested more thoroughly Amazon and LinkedIn and... there are places where the current filters break the sites. I'm sorry about that.

I also tried running npm test, but tests keep failing with error Cannot find module '../../lib/tldts/index.esm.min.js' from 'src/main/url.js' npm downloads that file to node_modules/tldts-experimental/dist/index.esm.min.js instead. Is this normal?

codecov-io commented 3 years ago

Codecov Report

Merging #137 (8f6bb8e) into master (a2d978f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          10       10           
  Lines         629      629           
=======================================
  Hits          626      626           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2d978f...8f6bb8e. Read the comment docs.

tumpio commented 3 years ago

Thanks for the PRs!

I also tried running npm test, but tests keep failing with error Cannot find module '../../lib/tldts/index.esm.min.js' from 'src/main/url.js' npm downloads that file to node_modules/tldts-experimental/dist/index.esm.min.js instead. Is this normal?

Did you run npm install? I've setup it so that it copies over the tldts library bundle file.

geeknik commented 3 years ago

If I import your rule changes into my current install will they overwrite my rules, delete my rules or play nicely and merge with no problems?

ArenaL5 commented 3 years ago

Thanks for the PRs!

Thank you!

Did you run npm install? I've setup it so that it copies over the tldts library bundle file.

...no, I hadn't. I really should get into the habit of trying that first for every project.

npm install; npm test works correctly.

If I import your rule changes into my current install will they overwrite my rules, delete my rules or play nicely and merge with no problems?

Last time I played with this (before tumpio split the rules), modified rules overwrote previous rules, new rules merged with the others, and no rules were deleted. I suppose it just chooses the most recent rule for any given UUID.