search

tun2proxy / rust-tun

TUN device creation and handling.
https://docs.rs/tun2/
30 stars 13 forks source link

Custom loading of wintun.dll should be a feature #75

Closed cavivie closed 3 weeks ago

cavivie commented 3 weeks ago

Custom loading of wintun.dll should be a feature that can reduce the dependence on libloading.

cavivie commented 3 weeks ago

@blechschmidt @ssrlive What do you think?

ssrlive commented 3 weeks ago

libloading crate is always in the dependencies list. so it's no matter.

cavivie commented 3 weeks ago

Forgive me for missing the context, we always use libloading to load wintun.dll, not only when customizing the path. Just close it.

cavivie commented 3 weeks ago

However, I think the current platform configuration default value does not obviously point to wintun.dll. Should we specify the default value in the platform configuration instead of replacing a magic str wintun.dll in device mod? In addition, the path parameter of custom_wintun_path should probably point to a string instead of option. If these arguments hold water, then I will make PRs for them.

ssrlive commented 3 weeks ago

OK. PR welcome.