tuna / danmaQ

danmaku implemented in Qt5
GNU General Public License v3.0
188 stars 46 forks source link

Rearrange the class names, file names #47

Closed noirgif closed 6 years ago

noirgif commented 6 years ago

Since the class name of main window is changed, the file names and class names doesn't match quite well. So it's preferable to rename these files, for example, like below:

danmaku.h -> danmaq.hpp
danmaku_ui.{cpp, h} -> Danmaku.{cpp, hpp}
danmaku_window.{cpp, h} -> DMWindow.{cpp, hpp}
danmaq_app.{cpp, h} -> DMMainWindow.{cpp, hpp}

The include directives, the translation file, and cmake file are subject to this change.

Also, I'd recommend some class name change, but it's just my personal taste and I'll leave it open to comment :)

Harry-Chen commented 6 years ago

Actually I am planning on this and I quite agree with you. Since I am busy preparing for exams these days, it would be nice if you could offer help on this. In terms of details, 'DMCanvas' is a good name. Also I prefer common.hpp instead of danmaq.hpp. Other suggestions are good, just do it!

Harry-Chen commented 6 years ago

Solved by 872a6a0fdf9e916303213c215a981a1320627dd8.