search

tuna / mirror-web

Source code of the web interface of https://mirrors.tuna.tsinghua.edu.cn/
GNU General Public License v2.0
759 stars 294 forks source link

Fix #433 and #434 #435

Closed Crystal-RainSlide closed 2 months ago

Crystal-RainSlide commented 2 months ago

This PR should fix #433 and #434.

_includes/head.html

_src/entrypoints/app.ts

_src/components/IsoModal.vue

shankerwangmiao commented 2 months ago

This PR should fix #433 and #434.

_includes/head.html

  • removes an invalid integrity

As stated in #420, it is intended.

_src/entrypoints/app.ts

  • fixes the import of BootStrap Modal

This has been fixed in 55d34b3

  • removes an unnessary hash matching

The hash tag for iso download modal is intended for a link from an internal site in our university, and due to an issue of that site, the final composed URL contains suffix like: #iso-download?foo=bar. So the matching is necessary.

_src/components/IsoModal.vue

  • makes the Modal scrollable

Actually, adding modal-scrollable changes the style of the modal. Currently, scrolling is available even without that, but with a different style. I believe it is a design choice rather than an issue. So I decided to keep the current style.

  • adds a link to isoModal's hash

As I mentioned before, the hash tag is not intended to be exposed to general users, and as a result, no such link is added to the button.

shankerwangmiao commented 2 months ago

Thanks again for helping us improve, but I have to close this PR since the main issue has been addressed.