tunapanda / funzo-app

Cordova app running ember and h5p
2 stars 3 forks source link

Fix all jshint warnings #107

Closed usernamenumber closed 8 years ago

usernamenumber commented 8 years ago

This includes all of the warnings listed below, and the app seems to work, but a quick sanity check would be nice.

ember test fails, but then it does that with a clean checkout of master for me.

pods/application/adapter.js: line 18, col 25, Expected '===' and instead saw '=='.
pods/application/route.js: line 50, col 22, 'reject' is defined but never used.
pods/application/route.js: line 30, col 20, 'TinCan' is not defined.
pods/application/serializer.js: line 6, col 19, Expected '===' and instead saw '=='.
pods/book-manager/service.js: line 1, col 1, 'LocalFileSystem' is defined but never used.
pods/book/controller.js: line 17, col 60, 'i' is defined but never used.
pods/book/controller.js: line 2, col 9, '$' is defined but never used.
pods/book/model.js: line 11, col 10, 'Ember' is not defined.
pods/book/section/route.js: line 30, col 47, Expected an assignment or function call and instead saw an expression.
pods/book/section/route.js: line 38, col 47, Expected an assignment or function call and instead saw an expression.
pods/book/section/route.js: line 45, col 47, Expected an assignment or function call and instead saw an expression.
pods/components/a-book/component.js: line 299, col 20, 'e' is defined but never used.
pods/components/a-book/component.js: line 369, col 20, Expected '{' and instead saw 'prev'.
pods/crypto/service.js: line 14, col 13, 'rendered' is defined but never used.
pods/index/controller.js: line 14, col 49, 'books' is defined but never used.
pods/section/model.js: line 1, col 1, 'CryptoJS' is defined but never used.
pods/settings/controller.js: line 9, col 5, 'xapi' is defined but never used.
pods/user/model.js: line 1, col 8, 'Ember' is defined but never used.
Jakeii commented 8 years ago

We can use travis to test this ;)

usernamenumber commented 8 years ago

Well, Travis fails, but that's expected right? Since I assume it's not just running jshint but the ember tests as well. Any objection to going ahead and merging what we have for now?

usernamenumber commented 8 years ago

merged via another branch