search

tunapanda / funzo-app

Cordova app running ember and h5p
2 stars 3 forks source link

Display one page instead of two at a time? #35

Closed usernamenumber closed 8 years ago

usernamenumber commented 8 years ago

Especially for smaller devices, I suggest that displaying one page at a time is a better default than the current two.

I tried setting pagesPerScreen to 1 in the places where it appears in book-section/component.js, but it just displays the first page with no apparent ability to advance to the next, even though they are all present and properly paginated in the source.

usernamenumber commented 8 years ago

Tested. Works great! One note for @Jakeii before I close this, though: it your commit msg suggests that you only mean for it to display one page when in portrait mode. I'm now seeing it in both portrait and landscape. I think a single page looks fine in both views, though. Any objection to closing this now?

Jakeii commented 8 years ago

No go ahead, it just decides which way to go by which of page horizontal or vertical is longer.