tunapanda / funzo-app

Cordova app running ember and h5p
2 stars 3 forks source link

Chart formatting #57

Closed jaylarson85 closed 8 years ago

jaylarson85 commented 8 years ago

Charts with columns run off the page and don't look good.

neerajkamdar commented 8 years ago

To fix this I need to add some classes to the table element. I looked in public/content/book/CSE/02-seven-major-sources-of-economic-progress.json but the book content seems to be encrypted.

Is there anyway to be able to edit the HTML for that?

usernamenumber commented 8 years ago

Right now the process is pretty manual (note to self that I need to document it). For now it might be easiest if you just told me what classes need to be added where. Is it consistent? Like, add this class to any image, or just to particular images?

On Mon, May 23, 2016 at 4:45 PM, Neeraj Kamdar notifications@github.com wrote:

To fix this I need to add some classes to the table element. I looked in public/content/book/CSE/02-seven-major-sources-of-economic-progress.json but the book content seems to be encrypted.

Is there anyway to be able to edit the HTML for that?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/tunapanda/funzo-app/issues/57#issuecomment-221090982

neerajkamdar commented 8 years ago

Ok .. I'll try to get a solution working (I can change the class names through the web inspector for testing) and then let you know what class names to add.

usernamenumber commented 8 years ago

I've given you access to the content. See email.

neerajkamdar commented 8 years ago

These column headings are too large. The best way to fix it would be abbreviate the heading and show the full form of the abbreviation below/above the table. Are we allowed to do that? Or will that be a copyright issue?

I have a solution for a responsive table but these headings are too large for that.

usernamenumber commented 8 years ago

should be fixed now.