search

tunapanda / funzo-app

Cordova app running ember and h5p
2 stars 3 forks source link

Add next/prev arrows to fix #66 #72

Closed usernamenumber closed 8 years ago

usernamenumber commented 8 years ago

The arrows should only appear on hover or if the navbar is displayed (e.g. if the page is clicked).

Proposed fix for #66. @Jakeii or @neerajkamdar, please review.

neerajkamdar commented 8 years ago

Would it be better to show the arrows by default instead of on hover? Just thinking that there is no hover state on touch devices so it wouldn't be obvious that tapping there would navigate the pages.

usernamenumber commented 8 years ago

My hope is that on a mobile device the swipe gesture is more intuitive, so we're mostly concerned about UX on desktop. In either case, I think if I was curious then one of the first things I'd do is click/tap the middle of the page, which would cause the arrows to display. IMO keeping the arrows always visible should be avoided if we can help it, because they're only useful for a few seconds until the user figures out the UI, and after that they're clutter forever.

Have I convinced you? :)

neerajkamdar commented 8 years ago

Yes :) If that was a fix mainly for desktop then it works. I wasn't aware the swipe to change page was already implemented. I agree that is the more intuitive way to navigate on mobile. Looks good to me but I'll let @Jakeii merge this as there are some ember changes too.