Pure CSS Pagination

[Jakeii]

I was reading about CSS columns and it sparked an idea to use them for our ereader.

This is pretty slick, way less code, great performance, and splits the pages perfectly.

I know I mentioned abandoning pages alltogether, but i think this straghtens it all out, shall i continue with this? @jaylarson85 @usernamenumber

Just needs a little more work to get feature parity with our current way of doing it.

TODO:

• [ ] Section and subsection links
• [x] Navigating to next section at the end of the current

[neerajkamdar]

Great idea to use CSS Columns Jake. Just tried it out and it's working quite well.

[usernamenumber]

We know Fred is fine with the page-based implementation, so I think we would need to ask if we wanted to do the single-page thing, but this is just a (hopefully) better implementation of what we've already agreed to deliver, so I'd say no.

My only concern would be about how the CSS-based approach performs on older devices. If we find that we have to have a hard cutoff for version X of the mobile OS/browser, I think that's something we should be sure Fred et al are on-board with.

--Brad

On Wed, Jun 15, 2016 at 9:32 AM, Neeraj Kamdar notifications@github.com wrote:

Great idea to use CSS Columns Jake. Just tried it out and it's working quite well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tunapanda/funzo-app/pull/75#issuecomment-226187756, or mute the thread https://github.com/notifications/unsubscribe/AALfvTIx2y8Cr4lJdBcnXB4mwQpp4Usoks5qL_7dgaJpZM4I2S27 .

[Jakeii]

@usernamenumber it seems fairly well supported http://caniuse.com/#feat=multicolumn , but I thought we were only relying on browsers for the demo we did?

[usernamenumber]

Well yeah, but we're on the hook for an actual product by August.

In any case, this sounds like a great find to me. Yay for not re-inventing wheels!

On Wednesday, June 15, 2016, Jake Lee Kennedy notifications@github.com wrote:

@usernamenumber https://github.com/usernamenumber it seems fairly well supported http://caniuse.com/#feat=multicolumn , but I thought we were only relying on browsers for the demo we did?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tunapanda/funzo-app/pull/75#issuecomment-226242594, or mute the thread https://github.com/notifications/unsubscribe/AALfvVkCGnYY5cM-XAVKu03O0GOEVNyhks5qMCgdgaJpZM4I2S27 .

[Jakeii]

OK nearly there, much better way now, also all the sections are loaded at once, so navigating between is seamless.

[Jakeii]

@usernamenumber I had to make some modifications to the book content, namely adding some attributes to the subsection anchors, and adding anchors for sections.

[usernamenumber]

Are those changes committed into funzo-cse (I see a commit from you, but it's ten days old, so I just want to check)? If not, could you please integrate it there so we know it won't get lost the next time we build a version of the book?

[Jakeii]

I'll wait till this is merged?

On Fri, 17 Jun 2016, 14:05 Brad Smith, notifications@github.com wrote:

Are those changes committed into funzo-cse https://github.com/usernamenumber/funzo-cse/ (I see a commit from you, but it's ten days old, so I just want to check)? If not, could you please integrate it there so we know it won't get lost the next time we build a version of the book?

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/tunapanda/funzo-app/pull/75#issuecomment-226742261, or mute the thread https://github.com/notifications/unsubscribe/ABpqTtX3X9Ixzy90kLMI4Nz3cohl1mkcks5qMn9egaJpZM4I2S27 .

[Jakeii]

I think this is stable enough to merge? Changes to the content is in a PR https://github.com/usernamenumber/funzo-cse/pull/1