search

tunapanda / funzo-app

Cordova app running ember and h5p
2 stars 3 forks source link

move stuff up on the login page to leave room for keyboard #94

Closed usernamenumber closed 8 years ago

usernamenumber commented 8 years ago

My attempt at a quick fix for #89.

@Jakeii may have a better idea. If he hasn't responded in a bit, @mcantor please review and merge if it looks ok to you. Please test on mobile I can't do that at the moment, and have only tested in browser.

usernamenumber commented 8 years ago

Screenshot. Basically just moves everything up a bit, plus more helpful instructions.

screenshot from 2016-08-04 10-45-48

usernamenumber commented 8 years ago

Another thing to consider, which is not fixed by this, is that pressing Enter does nothing. I assume there's some handy Ember trick to do this easily. It's worth doing because I assume that will also cause mobile keyboards to display a handy Submit button so the user doesn't have to dismiss the keyboard to get at the submit button when it's obscured. If I can find how to do this quickly I'll add it to the PR, but I'm about to get on a plane. Whoever reviews this should have a crack at adding it if I haven't updated by the time you see this.