Interactive Book type: Javascript error - only one instance of babel-polyfill is allowed

mikedawson commented 4 years ago

Hi,

I've been using h5p-standalone to run H5P's offline and it's really great for that! Unfortunately a small minority of files, in particular interactive book, seem to have a javascript conflict. If you try the interactive book example from the h5p.org website, you will get the following Javascript error on both Chrome and Firefox:

Uncaught Error: only one instance of babel-polyfill is allowed
    at Object.<anonymous> (h5p-interactive-book.js:1)
    at Object.<anonymous> (h5p-interactive-book.js:1)
    at n (h5p-interactive-book.js:1)
    at Module.<anonymous> (h5p-interactive-book.js:10)
    at n (h5p-interactive-book.js:1)
    at h5p-interactive-book.js:1
    at h5p-interactive-book.js:1
h5p-interactive-book.js:10 Uncaught TypeError: Cannot read property 'title' of undefined
    at new e (h5p-interactive-book.js:10)
    at Object.i.newRunnable (frame.bundle.js:3)
    at HTMLDivElement.<anonymous> (frame.bundle.js:3)
    at Function.each (frame.bundle.js:3)
    at init.each (frame.bundle.js:3)
    at Object.i.init (frame.bundle.js:3)
    at HTMLDocument.<anonymous> (frame.bundle.js:3)
    at u (frame.bundle.js:3)
    at Object.fireWith [as resolveWith] (frame.bundle.js:3)
    at Function.ready (frame.bundle.js:3)

I'm not a Javascript expert, but it seems like babel-polyfill has been used in both h5p-standalone and in the above h5p content type. Babel-polyfill states that it should not be used in libraries for this reason.

Does anyone have any idea where babel-polyfill is being used in h5p-standalone? I am willing to prepare a pull request to deal with this. I think babel-polyfill should either be removed as a dependency (as it is already being used by H5P where needed) or there should be some kind of option for it.

mikedawson commented 4 years ago

H5P Standalone is not including or using babel-polyfill. The problem is that somehow H5PStandalone has decided to load the interactive book Javascript twice (which uses babel-polyfill, which then causes the error):

main