tunapanda / wp-h5p-xapi

Stores xAPI statements from H5P in a LRS
11 stars 19 forks source link

Add context.registration to statements #4

Open garemoko opened 8 years ago

garemoko commented 8 years ago

We should add a context.registration to statements that represents a particular refresh of/visit to the page the H5P sits on.

This could be achieved by generating the UUID here using code like this and appending it to statements here.

This would help to enable the LRS to distinguish between attempts at the content. See the discussion here.

limikael commented 8 years ago

Hm... Should the "registration session" be the page visit, or should it be the php login session?

In general, I think out policy for this plugin is that we can add as much information as we want. If there is something that is "controversial", then we can add that also, but with an option to turn it on and off or change behavior under an "advanced settings" tab in the settings.

In this case, are there clear reasons why it should be the page visit and not the php session you think? Or should there be a way to change it?

Apart from that, sounds like a good plan! Go ahead and send a pull request if you want!

limikael commented 8 years ago

Ping? :) I'm considering closing this issue, just because open issues are an eyesore to me. @garemoko have you given this any thought? If not, we can close it for now, and then we can always re-open it later.

garemoko commented 8 years ago

Hi. I'll try and take a look at this and respond tomorrow. Sorry for the delay!

limikael commented 8 years ago

Cool!

garemoko commented 8 years ago

Hi, sorry again for the delay.

The registration should be page visit because the H5P content resets every time you refresh the page. If progress was bookmarked, then PHP session would make more sense.

limikael commented 8 years ago

Makes sense

limikael commented 8 years ago

Hi @garemoko

Open source hacking = good karma, you know... :)

garemoko commented 8 years ago

@limikael ha! I won't discount that I might do this at some point, but lots of other priorities at the moment I'm afraid (some of them open source!)

limikael commented 8 years ago

:) Do you have a particular use case or user story or such where this would be useful? If so, then maybe it will motivate me to actually getting around to implementing it...

garemoko commented 8 years ago

It would allow you to report on all activity on a single visit to a page e.g. an attempt at a quiz made up of questions on a page.