tund / male

MAchine LEarning (MALE)
GNU General Public License v3.0
4 stars 1 forks source link

khanh giw #27

Closed khanhndk closed 7 years ago

khanhndk commented 7 years ago

Finish implement some basic function for GIW. I will update more functionality (such as log predictive)

tund commented 7 years ago

Thanks a @khanhndk . I think we should name the variable better, now it's hard to read your code.

tund commented 7 years ago

one more thing: could you please provide a test script: test_giw.py under directory: male/tests/male/models?

khanhndk commented 7 years ago

Could you please suggest me how to test it? I have just tested whether it work (no runtime error).

tund commented 7 years ago

oh, I meant a demo script (create an instance, add, del items, ..), don't need to validate the correctness.

khanhndk commented 7 years ago

I finished renaming variables and adding a testing file for GIW

tund commented 7 years ago

Looks beautiful. Thanks a @khanhndk