First of all, the authors create License for their project, which is a very good practice for me to learn from.
Branch Shanshan Zhao:
The directory structure is complicated, it takes me a while to find the java file used to record voice, which I guess is in the "main" folder.
There are many file in the directory which is not a program, maybe the intermediate product produced by some of the program. These files are here and there, but didn't know what these files are for, such as those ends in xml, and those filed named as "gradle". It might be better if could add come comment about the usage about these file in readme.
For java programs in speexnoisecancel folder:
good comments between lines of code, in consistent with principle of "easy to understand";
well defined constant and array, which in consistent with the principle of "ready for change";
Its better to use upper case for constant.
Branch Zhonghao Guo:
Directorystructure is clear, and have good comments on each file.
Good file name to help understand the function of each program.
The style of code have some improve space, such as space after comma, using upper case for constant, name each constant properly to help "easy to understand(ETU)" quality.
Branch Chiwei Tung
Need more comments to help understanding.
Code is well organized but have space to improve style.
First of all, the authors create License for their project, which is a very good practice for me to learn from.
Branch Shanshan Zhao:
The directory structure is complicated, it takes me a while to find the java file used to record voice, which I guess is in the "main" folder.
There are many file in the directory which is not a program, maybe the intermediate product produced by some of the program. These files are here and there, but didn't know what these files are for, such as those ends in xml, and those filed named as "gradle". It might be better if could add come comment about the usage about these file in readme.
For java programs in speexnoisecancel folder:
Branch Zhonghao Guo:
Directorystructure is clear, and have good comments on each file.
Good file name to help understand the function of each program.
The style of code have some improve space, such as space after comma, using upper case for constant, name each constant properly to help "easy to understand(ETU)" quality.
Branch Chiwei Tung
Need more comments to help understanding.
Code is well organized but have space to improve style.