search

tungd / elixir-dns

DNS library for Elixir
BSD 3-Clause "New" or "Revised" License
114 stars 37 forks source link

Implement DOH Client #30

Open NullOranje opened 4 years ago

NullOranje commented 4 years ago

Implementation of DNS Queries over HTTPS (DOH). Uses RFC 8484 POST request only.

tungd commented 4 years ago

Hi @NullOranje , thanks a lot for contributing! However I don't think the change is a good fit for this library. The only reason I have is that the library is aim to be small and only have small dependencies, so that it can be used in embedded environment as well. While the PR doesn't introduce a lot of new code, it does indeed introduce one big dependencies that is Poison.

I'd be happier to separate the package into dns-doh or dns-over-https, and have it depends on dns just for the data structure. I'll investigate how to have a multi-package repo to include the PR later this week.