Closed Fitblip closed 3 years ago
Hey @tungd, I think this is ready to go now if you don't mind reviewing!
Merged! Thanks a lot for contributing. A new release will be published to Hex soon. 🎉
Wonderful, thanks @tungd :). Thanks for the speedy merge and for such a great library!
@Fitblip version v2.2.0 has been released and is now available on Hex.
Hi there!
This PR does 3 main things:
:tcp
option forDNS.resolve
andDNS.query
, which fixes #24. It looks like this:import Socket.Datagram
and calling UDP functions directly to better differentiate thesend!
/recv!
functions now that there is TCP connections too. I also added 5 second timeouts to both TCP and UDP calls, which fixes #31 (and supersedes #35, which I'll be closing)DNS.ResourceOpt
module to the top ofresource.ex
, without it there the library is unable to be used due to a breaking change in #32. I submitted #34, but will also be closing it in lieu of this PR.Minor things
2.2.0
since this introduces a new feature 🚀