replace custom dns implementation with :inet_res.resolve

tungd / elixir-dns

DNS library for Elixir

BSD 3-Clause "New" or "Revised" License

114 stars 37 forks source link

replace custom dns implementation with :inet_res.resolve #46

Closed BrendanBall closed 2 years ago

BrendanBall commented 2 years ago

OTP built in DNS resolution already does a lot of work implementing more options. This library should just wrap OTP primarily so we can use structs instead of records in Elixir. PS. This makes some breaking changes to the API

tungd commented 2 years ago

@BrendanBall 👋 . Thank you so much for the PR. Seems good. Let me look into the failed CI this weekend.

BrendanBall commented 2 years ago

Np, glad to help. Glad that you already did most of the work converting the OTP records into structs :)

tungd commented 2 years ago

@BrendanBall FYI, this is included with v2.4.0, and is also available on Hex now.

BrendanBall commented 2 years ago

thanks @tungd , glad you got it merged and released :)