tungs / timecut

Node.js program to record smooth movies of web pages with JavaScript animations
BSD 3-Clause "New" or "Revised" License
623 stars 72 forks source link

Capturing hangs after some frames #33

Closed danish-pyxis closed 4 years ago

danish-pyxis commented 4 years ago

Promise in timesnap p = timeHandler.goToTimeAndAnimateForCapture(browserFrames, marker.time);

does not get resolved after some frames and puppeteer hangs infinitely.

As a workaround, I have used a timeout to detect unhandled promise but its letting me destroy that process.

Can we discuss - why is this odd behaviour?

tungs commented 4 years ago

Does this happen for all webpages? If it's for a specific web page, could you post it?

tungs commented 4 years ago

Let's move the discussion over to tungs/timesnap#41, since that's likely where the issue originates