search

tungs / timesnap

Node.js program that takes screenshots at smooth intervals of web pages with JavaScript animations
BSD 3-Clause "New" or "Revised" License
234 stars 57 forks source link

Timesnap dont reject on error #46

Closed jnx closed 3 years ago

jnx commented 4 years ago

When something like an error happens when you render it doesn't throw a promise reject.

ex. The log from timesnap says Navigation failed because browser has disconnected the render stops but we get a resolve from timesnap as if the render was complete

tungs commented 3 years ago

Looks like this was fixed with #47, please reply if this is still an issue