search

tunisiano187 / Chocolatey-packages

Chocolatey automatic packages from tunisiano
https://community.chocolatey.org/profiles/tunisiano
GNU Affero General Public License v3.0
7 stars 18 forks source link

[Bug] broken error handling in keepass-plugin-webautotype #2837

Closed DonEstefan closed 4 years ago

DonEstefan commented 4 years ago

Describe the bug

Seems like the error handling is broken for cases when chocolatey is used to install the plugin over an existing installation.

2020-08-13 14:33:32,608 3508 [INFO ] - VERBOSE: Removing any plugin with name WebAutoType.plgx in C:\Program Files (x86)\KeePass Password Safe 2\ to prevent duplicate plugin loading
2020-08-13 14:33:32,635 3508 [ERROR] - ERROR: Cannot compare "WebAutoType.plgx" because it is not IComparable.

Probably caused by line 64 and 66 in https://github.com/tunisiano187/Chocolatey-packages/blob/master/automatic/keepass-plugin-webautotype/tools/chocolateyInstall.ps1

To Reproduce Steps to reproduce the behavior:

  1. install the plugin outside of chocolatey
  2. run choco install keepass-plugin-webautotype
  3. See error on command line and in installation log

Desktop (please complete the following information):

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.99. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

tunisiano187 commented 4 years ago

OK, missing count... Thank you It should be OK for the next version.