tunisiano187 / WME-send-to-slack

Script to send (Un)lock/Closures/Open/Validations requests to slack, Discord, Telegram, GForm
https://wmests.bowlman.org
GNU General Public License v3.0
4 stars 7 forks source link

Support for Discord forum channels #123

Closed Uwe4Waze closed 7 months ago

Uwe4Waze commented 8 months ago

Fixes #122

Proposed changes in this pull request:


This change is Reviewable

GyllieGyllie commented 7 months ago

Hey @Uwe4Waze,

I've been looking over this code again and wonder if we need the auto detect for channel type or if we can just add it into the data that holds the webhooks anyways. This way it's less prone to issues with the auto detection logic.

Open to hear what you think.

Uwe4Waze commented 7 months ago

Hi @GyllieGyllie, of course we can add the channel type information to the database structure. To get this information, you need to ask the community admins if they are still using the script with text channels or if they have switched to forum channels in the meantime and therefore do not (cannot) use the script at the moment. The latter is the case for Germany, for example. If a community is planning to change the channel type, this must be coordinated in order to provide an adapted WMESTSData.js in a timely manner. Greetings Uwe

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

GyllieGyllie commented 7 months ago

I will merge it as is for now so it at least works again while we look into the other option