Closed Uwe4Waze closed 7 months ago
Hey @Uwe4Waze,
I've been looking over this code again and wonder if we need the auto detect for channel type or if we can just add it into the data that holds the webhooks anyways. This way it's less prone to issues with the auto detection logic.
Open to hear what you think.
Hi @GyllieGyllie, of course we can add the channel type information to the database structure. To get this information, you need to ask the community admins if they are still using the script with text channels or if they have switched to forum channels in the meantime and therefore do not (cannot) use the script at the moment. The latter is the case for Germany, for example. If a community is planning to change the channel type, this must be coordinated in order to provide an adapted WMESTSData.js in a timely manner. Greetings Uwe
Issues
0 New issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
I will merge it as is for now so it at least works again while we look into the other option
Fixes #122
Proposed changes in this pull request:
Discord: supporting Forum channel
Discord: auto-detecting channel type (Text channel/Forum channel)
Discord: slack-compatible Webhook URLs remain supported; no database changes needed
Discord: slightly changed request format
Discord: added signature to request to identify script
[x] PR as been tested
[x] Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
[x] Read contribution guide
This change is