tunisiano187 / WME-send-to-slack

Script to send (Un)lock/Closures/Open/Validations requests to slack, Discord, Telegram, GForm
https://wmests.bowlman.org
GNU General Public License v3.0
4 stars 7 forks source link

[Bug] Deprecations of Discord WebHook sendings #37

Open ordonezgs opened 4 years ago

ordonezgs commented 4 years ago

Since the script is using Discord Slack Compatible WebHook and discord has estatement of:

https://github.com/tunisiano187/WME-send-to-slack/blob/8d6472a574e9618a9a50a896e52fb5c55c993dc3/WME-send-to-slack.user.js#L556-L573

_We do not support Slack's channel, icon_emoji, mrkdwn, or mrkdwn_in properties._

We need to find a way to replace this.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.90. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

tunisiano187 commented 4 years ago

Now that they are different cases (case statement) we can add a break; and have a totally different approach (like for telegram)

Le mer. 22 juil. 2020 à 22:53, ordonezgs notifications@github.com a écrit :

Since the script is using Discord Slack Compatible WebHook and discord has estatement of:

https://github.com/tunisiano187/WME-send-to-slack/blob/8d6472a574e9618a9a50a896e52fb5c55c993dc3/WME-send-to-slack.user.js#L556-L573

We do not support Slack's channel, icon_emoji, mrkdwn, or mrkdwn_in properties.

We need to find a way to replace this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tunisiano187/WME-send-to-slack/issues/37, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOQG6YJ4QA4WPFERBG3IQDR45GUXANCNFSM4PFCZPQQ .

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

ordonezgs commented 4 years ago

Yes, needing time

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

stale[bot] commented 4 years ago

This issue has been automatically closed because it has not had any comments for a while, feel free to reopen it if needed

ordonezgs commented 1 month ago

Not, sure... but actually I think that the script version has a modified part for Discord. We need to check if this it's corrected to close the issue.