search

tunisiano187 / WME-send-to-slack

Script to send (Un)lock/Closures/Open/Validations requests to slack, Discord, Telegram, GForm
https://wmests.bowlman.org
GNU General Public License v3.0
4 stars 7 forks source link

[Bug] WME design change, locks and validation icons are missing and settings tab not showing. #84

Closed tunisiano187 closed 1 year ago

tunisiano187 commented 2 years ago

Locks are back with: https://github.com/tunisiano187/WME-send-to-slack/commit/0a816f42ed43e75f808eb9b2dd9bb8f6d6dd1936

tunisiano187 commented 2 years ago

2022.06.22.02 solve missing locks

tunisiano187 commented 2 years ago

2022.06.23.01 Solves missing Validation icon https://github.com/tunisiano187/WME-send-to-slack/commit/355d04b13b526e3203e1c233d1a11c8fbd8389ce

tunisiano187 commented 2 years ago

Yes

Le dim. 10 juil. 2022 à 08:32, stale[bot] @.***> a écrit :

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

— Reply to this email directly, view it on GitHub https://github.com/tunisiano187/WME-send-to-slack/issues/84#issuecomment-1179666590, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOQG62TNUFQOXRG57LGPFDVTJVALANCNFSM5ZKBZDYQ . You are receiving this because you were assigned.Message ID: @.***>

EdwardNavarro commented 2 years ago

Hi @tunisiano187 ,

I found that settings icon and tab not work because is needed to update the selectors in lines 774 and 775, please try this:

$(".tabs-container ul.nav.nav-tabs").append(b);
$(".contents .tab-content").append('<div class="tab-pane" id="segment-edit-settings"><div class="settings">Slack</div></div>');

replace as this:

$("#user-info .flex-parent #user-tabs .nav-tabs").append(b);
$("#user-info .flex-parent .tab-content").append('<div class="tab-pane" id="segment-edit-settings"><div class="settings">Slack</div></div>');

Other issue I got was that jQuery selectors not work if $ variable is not declared globally, so, in this case I did it by putting following after the UserScript section (line 28), and everything works well.

/* global $ */
tunisiano187 commented 1 year ago

Still needs to be done

Le sam. 15 oct. 2022 à 23:39, stale[bot] @.***> a écrit :

Closed #84 https://github.com/tunisiano187/WME-send-to-slack/issues/84 as completed.

— Reply to this email directly, view it on GitHub https://github.com/tunisiano187/WME-send-to-slack/issues/84#event-7595540640, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOQG67BIWEITKZTE45MSTLWDMQBJANCNFSM5ZKBZDYQ . You are receiving this because you were mentioned.Message ID: @.*** com>

grosshad commented 1 year ago

Hi @tunisiano187 ,

I found that settings icon and tab not work because is needed to update the selectors in lines 774 and 775, please try this:

$(".tabs-container ul.nav.nav-tabs").append(b);
$(".contents .tab-content").append('<div class="tab-pane" id="segment-edit-settings"><div class="settings">Slack</div></div>');

replace as this:

$("#user-info .flex-parent #user-tabs .nav-tabs").append(b);
$("#user-info .flex-parent .tab-content").append('<div class="tab-pane" id="segment-edit-settings"><div class="settings">Slack</div></div>');

Other issue I got was that jQuery selectors not work if $ variable is not declared globally, so, in this case I did it by putting following after the UserScript section (line 28), and everything works well.

/* global $ */

with version 2022.08.15.01 this patch need to be applied to lines 744 and 745