tunlrs / mono

Server for Tunlrs service.
MIT License
2 stars 0 forks source link

feat: add in error handling and resolutions for empty TCP pipes #17

Closed Serpent03 closed 1 week ago

Serpent03 commented 1 week ago

Add in error handling and println!() logs for clarity(for the time being).

Fix hangups from empty TCP pipes(not tested fully).

sohamjaiswal commented 1 week ago

No, dont use println, shift to a proper logging package, m open to using any crate like tracing, slog or log

Serpent03 commented 1 week ago

No, dont use println, shift to a proper logging package, m open to using any crate like tracing, slog or log

Then tracing is probably a better approach to logging(atleast intermediately) since it supports concurrent operation logging

Should we open another issue and then submit a PR in relation to that for enabling logging globally?

sosweetham commented 1 week ago

No, dont use println, shift to a proper logging package, m open to using any crate like tracing, slog or log

Then tracing is probably a better approach to logging(atleast intermediately) since it supports concurrent operation logging

Should we open another issue and then submit a PR in relation to that for enabling logging globally?

sounds good to me

sosweetham commented 1 week ago

just open an issue and i'll just link it here for reference, after that i'll merge

Serpent03 commented 1 week ago

Merged and deleted after opening issue #18