search

tunnckoCore / express-better-ratelimit

Express.js request rate limiter
http://j.mp/1stW47C
Other
10 stars 0 forks source link

Question: Is this IPv6 safe? #9

Closed jcalfee closed 8 years ago

jcalfee commented 8 years ago

When I log the IP address here: https://github.com/tunnckoCore/express-better-ratelimit/blob/v1.1.2/index.js#L56

I see this value: ::ffff:127.0.0.1

Is is possible for an attacker to change there IPv6 part of the address above remotely and programmatically in effect bypassing the rate limiter?

jcalfee commented 8 years ago

Wait, I see .. this is not IPv6, it is just the hex of the IPv4... Ok, I think we are safe. Never-mind.

tunnckoCore commented 8 years ago

It's ipchecker related, yea.

Thanks using it, but it's lil' bit out-dated. PRs welcome. I'll be back soon on Github and my repos.