search

tunnelvisionlabs / LangSvcV2

"Language Service V2" reference repository
Other
86 stars 38 forks source link

Visual studio 2017 support #78

Closed areller closed 7 years ago

areller commented 7 years ago

When are you planning to support visual studio 2017? I have the RC version and projects that rely on antlr tools don't compile.

sharwell commented 7 years ago

Hi @lekararik,

I haven't yet updated the project to support Visual Studio 2017. However, the build support for ANTLR should not be relying on this at all, so that's very concerning. A couple questions:

  1. Are you using ANTLR 3 or ANTLR 4?
  2. Have you installed the ANTLR tools from NuGet? If so, can you list the packages (or link to the project if one is open source)?
areller commented 7 years ago

@sharwell - Thank you for the fast response.

  1. I am using Antlr4
  2. I have no problem downloading from nuget/compiling projects that use Antlr4. I have problem compiling projects that use Antlr tools for visual studio

image (Antlr language support)

Here is an error i get when i import such project (it buiilds on visual studio 2015 but doesn't build on visual studio 2017):

image

ben-may commented 7 years ago

@sharwell I also see this problem using the Antlr tools for visual studio. And receive the same error as @lekararik Any chance there is a bug-fix/patch coming for this soon?

sharwell commented 7 years ago

It's on my list to install the RC tonight to start resolving a few issues in different extensions I participate in. I'll try to reproduce this as a high-priority item.

ben-may commented 7 years ago

Thanks! appreciate it!

ben-may commented 7 years ago

@sharwell debugging it seems that the 'HandleOutputDataReceived' callback registered to process.OutputDataReceived when running ikvm.exe is what ends up throwing the exception about Microsoft.Build.Framework.dll, if I comment out the OutputDataReceived and ErrorDataReceived registration, then everything runs ok (with the obvious exception that the GeneratedCodeFiles list doesn't get updated...

sharwell commented 7 years ago

@lekararik @ben-may I was able to reproduce this today. It turns out the problem in part of the ANTLR C# target itself, which is a different project. I filed tunnelvisionlabs/antlr4cs#173 and am closing this one as external.

areller commented 7 years ago

@sharwell Thank you for your help!