search

tunnelvisionlabs / ReferenceAssemblyAnnotator

IL weaver to add nullability annotations to .NET reference assemblies
MIT License
71 stars 8 forks source link

Support older versions of .NET Framework #26

Closed jnm2 closed 5 years ago

jnm2 commented 5 years ago

My company has some projects that extend third-party .NET Framework 3.5 software. We don't have control over the entry point, so these projects are largely stuck with the world as it was eleven years ago.

There doesn't seem to be any reason not to allow this package to annotate as far back as net35, does there? From the perspective of what I understand this package to do, net35 is net472, only with fewer APIs.

I extracted https://globalcdn.nuget.org/packages/tunnelvisionlabs.referenceassemblyannotator.1.0.0-alpha.53.nupkg to %userprofile%/.nuget/packages/tunnelvisionlabs.referenceassemblyannotator.1.0.0/alpha.53, deleted the signature, and changed the nuspec dependency to .NETFramework,3.5. The package then installs successfully.

Would you accept a PR to permit this scenario?

sharwell commented 5 years ago

The tool was intended to support net20 and newer.

sharwell commented 5 years ago

It looks like #27 did fix this after all 😄