Remove [DisallowNull] on IEqualityComparer<T>.GetHashCode - Githubissues

tunnelvisionlabs / ReferenceAssemblyAnnotator

IL weaver to add nullability annotations to .NET reference assemblies

MIT License

72 stars 8 forks source link

Remove [DisallowNull] on IEqualityComparer<T>.GetHashCode #46

Closed sharwell closed 4 years ago

sharwell commented 4 years ago

These [DisallowNull] attributes should be removed:

IEqualityComparer<T>.GetHashCode(T)
EqualityComparer<T>.GetHashCode(T)

The following scenarios are impacted:

For netcoreapp3.0 and newer targets, the reference assemblies should be rewritten to remove the existing attribute from the reference assembly
For earlier targets, the attributes should simply not be added during the rewrite process